Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check to see if cart uses only DAI #7079

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

mds1
Copy link
Contributor

@mds1 mds1 commented Jul 8, 2020

Closes #7056

During checkout, if the user selects DAI for each grant contribution in their cart, a special heuristic is used to estimate gas. Before this PR, this heuristic would be accidentally applied any time a cart used the same token for each grant in their cart, regardless of whether or not that token was DAI.

This PR resolves that so the gas estimation heuristic is now only used for carts with DAI

cc @owocki

@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #7079 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7079      +/-   ##
==========================================
+ Coverage   26.25%   26.27%   +0.02%     
==========================================
  Files         300      300              
  Lines       29323    29323              
  Branches     4318     4318              
==========================================
+ Hits         7699     7705       +6     
+ Misses      21353    21347       -6     
  Partials      271      271              
Impacted Files Coverage Δ
app/dashboard/embed.py 31.60% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e834499...c2d1a09. Read the comment docs.

@thelostone-mc thelostone-mc merged commit 18aa9c6 into gitcoinco:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gitcoin Grant Donation from cart didn't go through.
2 participants