Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: count distinct registrants to avoid duplicates #7071

Conversation

walidmujahid
Copy link
Contributor

@walidmujahid walidmujahid commented Jul 7, 2020

Description

HackathonRegistration instances are prone to have duplicates as described here #7070. This pull requests ensures that hacker_count counts only distinct registrants for a hackathon event. Tested locally.

Refers/Fixes

fixes #7051
related #7070

@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #7071 into master will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7071      +/-   ##
==========================================
+ Coverage   26.30%   26.32%   +0.02%     
==========================================
  Files         301      301              
  Lines       29241    29241              
  Branches     4295     4295              
==========================================
+ Hits         7691     7697       +6     
+ Misses      21279    21273       -6     
  Partials      271      271              
Impacted Files Coverage Δ
app/dashboard/views.py 10.60% <0.00%> (ø)
app/dashboard/embed.py 31.60% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a93f17c...def6a4c. Read the comment docs.

@thelostone-mc thelostone-mc merged commit 4ba5ed9 into gitcoinco:master Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Participants tab isn't showing the correct numbers.
3 participants