Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds profile_for_clr for clr calcs #7066

Merged
merged 1 commit into from
Jul 7, 2020
Merged

adds profile_for_clr for clr calcs #7066

merged 1 commit into from
Jul 7, 2020

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Jul 6, 2020

the work for the convo that franjk/aditya/i did today

@codecov
Copy link

codecov bot commented Jul 6, 2020

Codecov Report

Merging #7066 into stable will decrease coverage by 0.00%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           stable    #7066      +/-   ##
==========================================
- Coverage   26.27%   26.27%   -0.01%     
==========================================
  Files         301      301              
  Lines       29286    29290       +4     
  Branches     4305     4307       +2     
==========================================
+ Hits         7695     7696       +1     
+ Misses      21320    21318       -2     
- Partials      271      276       +5     
Impacted Files Coverage Δ
app/grants/clr.py 0.00% <0.00%> (ø)
app/grants/models.py 44.92% <25.00%> (-0.14%) ⬇️
app/grants/admin.py 41.32% <100.00%> (ø)
app/quests/views.py 16.22% <0.00%> (ø)
app/dashboard/views.py 10.60% <0.00%> (ø)
...rketing/management/commands/no_applicants_email.py 0.00% <0.00%> (ø)
...eting/management/commands/assemble_leaderboards.py 39.73% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77c8a6a...8ade449. Read the comment docs.

Copy link
Contributor

@frankchen07 frankchen07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owocki owocki merged commit 8a33240 into stable Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants