Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: set CLR_END_DATE #7057

Merged
merged 1 commit into from
Jul 6, 2020
Merged

chore: set CLR_END_DATE #7057

merged 1 commit into from
Jul 6, 2020

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Jul 3, 2020 •
edited
Loading

Description
  • set CLR_END_DATE if not default to current.timezone
  • removed defaults and added null checks in place
  • updated code to use CLR_END_DATE

owocki
owocki reviewed Jul 3, 2020
View reviewed changes
app/grants/clr.py

try:
CLR_END_DATE
except NameError:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this for

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be extra safe to ensure no one comments out CLR_END_DATE while round is active
That check ensure if that variable is not defined -> set it to current timezone

@owocki
Copy link
Contributor

owocki commented Jul 3, 2020

didnt test but LGTM

@owocki
Copy link
Contributor

owocki commented Jul 3, 2020

at high level

@thelostone-mc thelostone-mc merged commit 9b485e1 into stable Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owocki owocki owocki left review comments

@danlipert danlipert danlipert approved these changes

@frankchen07 frankchen07 Awaiting requested review from frankchen07

@octavioamu octavioamu Awaiting requested review from octavioamu

@PixelantDesign PixelantDesign Awaiting requested review from PixelantDesign

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thelostone-mc @owocki @danlipert