Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix sync_amount API + prettify conversion table #7049

Merged
merged 2 commits into from
Jul 3, 2020

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Jul 3, 2020

Description
  • If ETH/ USDT conversion isn't found -> the value is set to null
  • Fixes issue where /sync_amount returns 500 cause conversion rate of ETH was not set

Reported over at https://gitcoincore.slack.com/archives/C013CL18L72/p1593716951050300

Testing

Kapture 2020-07-03 at 6 53 56

Screenshot 2020-07-03 at 6 46 30 AM

Admin View
image

@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #7049 into master will increase coverage by 0.02%.
The diff coverage is 44.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7049      +/-   ##
==========================================
+ Coverage   26.34%   26.36%   +0.02%     
==========================================
  Files         300      300              
  Lines       29156    29160       +4     
  Branches     4283     4283              
==========================================
+ Hits         7682     7689       +7     
+ Misses      21204    21200       -4     
- Partials      270      271       +1     
Impacted Files Coverage Δ
app/dashboard/helpers.py 14.46% <41.66%> (-0.10%) ⬇️
app/economy/admin.py 64.28% <100.00%> (+1.32%) ⬆️
app/dashboard/embed.py 31.60% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd59168...7821f34. Read the comment docs.

@danlipert danlipert merged commit 20491a0 into gitcoinco:master Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants