Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Super Responsive Quest Table #7026

Merged
merged 28 commits into from
Jul 5, 2020
Merged

Super Responsive Quest Table #7026

merged 28 commits into from
Jul 5, 2020

Conversation

molecula451
Copy link
Contributor

@molecula451 molecula451 commented Jul 1, 2020

Description

Following the standard structure

respomsive

  • Add Quest Owner row when not in 'created' level
  • Change "Play" row to "Stage"
  • Some icons
Refers/Fixes
Testing

Highly responsive on the Amazon Fire tablet

@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #7026 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7026      +/-   ##
==========================================
+ Coverage   26.34%   26.36%   +0.02%     
==========================================
  Files         300      300              
  Lines       29156    29156              
  Branches     4283     4283              
==========================================
+ Hits         7682     7688       +6     
+ Misses      21204    21198       -6     
  Partials      270      270              
Impacted Files Coverage Δ
app/dashboard/embed.py 31.60% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd59168...36b45af. Read the comment docs.

@molecula451 molecula451 marked this pull request as ready for review July 1, 2020 19:59
@molecula451 molecula451 marked this pull request as draft July 2, 2020 01:57
@molecula451 molecula451 marked this pull request as ready for review July 2, 2020 23:12
@molecula451
Copy link
Contributor Author

push it @thelostone-mc

@thelostone-mc thelostone-mc merged commit 3b31741 into gitcoinco:master Jul 5, 2020
@owocki
Copy link
Contributor

owocki commented Jul 6, 2020

how do i actually click into the quest now?

https://bits.owocki.com/WnubmQzv

theres no play button and clicking the row doesnt do anything

@owocki
Copy link
Contributor

owocki commented Jul 6, 2020

https://bits.owocki.com/OAuBokEv

users are not going to be able to to find the play button on the right
also just adding a x-scroll is not responsive. it actually needs to fit in the users view.

the spec required that clicking anywhere on the row would take the user into playing the quest

@molecula451
Copy link
Contributor Author

https://bits.owocki.com/OAuBokEv

users are not going to be able to to find the play button on the right
also just adding a x-scroll is not responsive. it actually needs to fit in the users view.

the spec required that clicking anywhere on the row would take the user into playing the quest

@owocki Totally. couldn't reproduce this locally (You can see screenshots). Put it on a quick fix in #7065 for production. Will still dive into

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants