Reduce carts post requests #7019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mds1
requested review from
danlipert,
frankchen07,
octavioamu,
PixelantDesign and
thelostone-mc
as code owners
mds1
force-pushed
the
reduce-carts-post-requests
branch
from
04cfd9a to
812b3d8
Compare
|
Updated to store off the payload before any processing happens, so this is now ready for review |
thelostone-mc
approved these changes
Jul 1, 2020
danlipert
approved these changes
Jul 1, 2020
|
@mds1 looks good but Travis is failing - can you rebase against the latest master so we can re-trigger Travis since it was against stable previously - thanks! |
mds1
force-pushed
the
reduce-carts-post-requests
branch
from
812b3d8 to
c50195a
Compare
|
@danlipert Should be all set now! |
octavioamu
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7002
Changes/notes:
/grants/bulk-fund/grant_id/grant_slug/fundendpoint. The difference is that now the payload expects arrays of data for the object fields that differ for each donation.postToDatabase()function ofcart.jssends the POST request, it does not wait for the response before proceedingperftools.models.JSONStoreis used to save the POST payload before any processing happenscc @owocki @apbendi