Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for the chat application move all logger calls to info instead of deb… #6991

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

androolloyd
Copy link
Contributor

…ug or error

Description

Migrates logger.debug and logger.error to logger.info for the django chat application

Refers/Fixes
Testing

@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #6991 into stable will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           stable    #6991   +/-   ##
=======================================
  Coverage   26.46%   26.46%           
=======================================
  Files         299      299           
  Lines       28850    28850           
  Branches     4228     4228           
=======================================
  Hits         7635     7635           
  Misses      20939    20939           
  Partials      276      276           
Impacted Files Coverage Δ
.../management/commands/setup_hackathon_event_chat.py 0.00% <0.00%> (ø)
...management/commands/sync_event_bounties_to_chat.py 0.00% <0.00%> (ø)
app/chat/management/commands/sync_users_to_chat.py 0.00% <0.00%> (ø)
app/chat/tasks.py 14.01% <0.00%> (ø)
app/chat/views.py 29.78% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b312aef...de07366. Read the comment docs.

@thelostone-mc
Copy link
Member

Why would we do this ?
A few of them seem like logger.error should be used right

@danlipert
Copy link
Contributor

@thelostone-mc just too many chat errors in sentry

@owocki
Copy link
Contributor

owocki commented Jun 26, 2020

A few of them seem like logger.error should be used right

i mean if were actually going to be diligent about cleaning up the errors as they pop up in sentry, then lets use logger.error for the ones that are actually errors. but right now were just needlessly burning sentry credits with errors we dont take action on. i dont know the application specific enough to know which should be in which category tho :-/

@androolloyd
Copy link
Contributor Author

We could leave the .error, as they are connection based ones, debug errors can be info as they aren handled exceptions.

@thelostone-mc thelostone-mc changed the base branch from stable to master July 1, 2020 03:17
@thelostone-mc thelostone-mc merged commit e0d10c8 into master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants