Fix for bottomVisible method scope. #6964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
androolloyd
requested review from
danlipert,
frankchen07,
octavioamu,
PixelantDesign and
thelostone-mc
as code owners
reverting manifest changes
Codecov Report
@@ Coverage Diff @@
## stable #6964 +/- ##
=======================================
Coverage 26.46% 26.46%
=======================================
Files 299 299
Lines 28829 28829
Branches 4226 4226
=======================================
Hits 7630 7630
+ Misses 20928 20923 -5
- Partials 271 276 +5
Continue to review full report at Codecov.
|
revert top nav changes
…into bugfix/project-pagination
danlipert
approved these changes
Jun 24, 2020
|
i cant say i really understand this code; so it gives me comfort that @danlipert approved them. |
thelostone-mc
approved these changes
Jun 24, 2020
octavioamu
added a commit
that referenced
this pull request
Jun 24, 2020
* Fix Firefox issue that showed red border for decimal inputs in cart (#6958) * New Grants txn Failed Email (#6791) * setup web preview url * implement render_grant_txn_failed * build template grant_txn_failed.html * management command for grant_txn_failed_email * fix missing returns after resolving conflicts * add bulk_add_url * move email specific style to grant_txn_failed.html * new approval checker helper script * fix comparing strings on allowance * fix featured bounty and balance checker * fix eslint card.js * Improve cart gas estimates for DAI, aDAI, cDAI, and ANT (#6961) * Quotation on Profile handle (#6957) * Improve cart gas estimates for DAI, aDAI, cDAI, and ANT Co-authored-by: Paul <[email protected]> * wallet improvments (#6952) * wallet improvments * avoid form submission * bounty requesting wallet * quest js dupe * Fix for bottomVisible method scope. (#6964) * fix for projects, the bottomVisible method was defined incorrectly * fixes for paginaiton of projects, as well as sorting by winners as default * restoring docker-compose * Update manifest.json reverting manifest changes * Update top_nav.html revert top nav changes * position the loading screen better inside the project directory * formalizes the types of conversion rates in the DB * 1 thing * fixes A few annoying things about kudso 1. now proudly shows the kudos artist 2. allows u to mind them in one fell swoop + change onwnership 3. stores the IPFS metadata in our DB for future keeping Co-authored-by: Matt <[email protected]> Co-authored-by: Sebastian T F <[email protected]> Co-authored-by: Owocki <[email protected]> Co-authored-by: Paul <[email protected]> Co-authored-by: Andrew Redden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where project-directory is not calling the bottomVisible method,
methods not defined inside the method object on vue objects are not available to the lexical scope of this.
Refers/Fixes
Testing