Share amount and tokens #6927
Merged
Share amount and tokens #6927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoek1
requested review from
danlipert,
frankchen07,
octavioamu,
PixelantDesign and
thelostone-mc
as code owners
owocki
reviewed
Jun 19, 2020
|
|
||
| for ele in grants_data: | ||
| # new format will support amount and token in the URL separated by ; | ||
| grant_data = ele.split(';') |
There was a problem hiding this comment.
is this backwards compatible with the old links that have already been shared out in the wild?
|
https://bits.owocki.com/RBuq96nd hmm it isnt working for me for some reason. i had 2 DAI grants and 1 ETH grant in my cart |
|
hmmm yeah it just seems to clear my cart. derp https://gitcoin.co/grants/cart/bulk-add/351;1;283,237;5;283,15;1;283,13;5;283,:owocki |
|
The current "share My cart" prefills automatically the domain with gitcoin.co, it needs substitute manually the domain of your host in testing |
danlipert
approved these changes
Jun 22, 2020
|
just tested this and it works fine. looks like its backwards compartible with the old style links too ( http://localhost:8000/grants/cart/bulk-add/567,143,:owocki ) cool! |
|
|
octavioamu
approved these changes
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://www.loom.com/share/092a487867f44753a6e56c43c80a00d2
Refers/Fixes
Testing