Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add is_clr_eligble option to a grant #6923

Merged
merged 1 commit into from
Jun 18, 2020
Merged

feat: add is_clr_eligble option to a grant #6923

merged 1 commit into from
Jun 18, 2020

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Jun 18, 2020

Description
  • add is_clr_eligible option to CLR which is defaulted to true
  • fix minor UI bugs in grants
  • update clr algo to fetch only grants which are eligible
  • update content stating clr is not eligible when a grant is not eligible (on grants landing + grants detail + cart )
  • added ability to toggle is is_clr_eligible via admin

@owocki + @danlipert -> made clr_prediction_curve a read only field in admin cause right now if you update a grant, since django admin can't read 2D array right and display it as flat string -> it messes up the data and stuff randomly breaks off
Until we figure that out -> It would be safer to update the curve via db (this was the same issue matt faced while updating the curve via admin)

Testing

https://share.vidyard.com/watch/ds4VLaLMxgfuQqNrjr3w2N?

@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #6923 into stable will increase coverage by 0.01%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           stable    #6923      +/-   ##
==========================================
+ Coverage   26.53%   26.55%   +0.01%     
==========================================
  Files         298      298              
  Lines       28673    28673              
  Branches     4191     4191              
==========================================
+ Hits         7608     7613       +5     
+ Misses      20795    20785      -10     
- Partials      270      275       +5     
Impacted Files Coverage Δ
app/grants/admin.py 42.93% <ø> (ø)
app/grants/clr.py 0.00% <0.00%> (ø)
app/grants/tasks.py 17.20% <ø> (ø)
app/grants/views.py 18.96% <ø> (-0.15%) ⬇️
app/grants/models.py 45.75% <100.00%> (+0.09%) ⬆️
app/quests/views.py 16.22% <0.00%> (ø)
app/dashboard/views.py 10.61% <0.00%> (ø)
...rketing/management/commands/no_applicants_email.py 0.00% <0.00%> (ø)
...eting/management/commands/assemble_leaderboards.py 39.83% <0.00%> (ø)
app/dashboard/utils.py 41.51% <0.00%> (+0.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc33397...2d4823f. Read the comment docs.

@thelostone-mc thelostone-mc merged commit febcc9c into stable Jun 18, 2020
@thelostone-mc thelostone-mc deleted the boolean branch June 27, 2020 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants