Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change Grant Categories #6913

Merged
merged 2 commits into from
Jun 18, 2020

Conversation

developerfred
Copy link
Contributor

@developerfred developerfred commented Jun 17, 2020

Description
Refers/Fixes

closes #6908

Testing

@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #6913 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6913      +/-   ##
==========================================
+ Coverage   26.93%   26.95%   +0.02%     
==========================================
  Files         297      297              
  Lines       28373    28373              
  Branches     4153     4153              
==========================================
+ Hits         7641     7647       +6     
+ Misses      20458    20452       -6     
  Partials      274      274              
Impacted Files Coverage Δ
app/dashboard/embed.py 31.60% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d898ef...81fa476. Read the comment docs.

@@ -116,8 +116,7 @@ <h5 class="mt-4">Categorization Information</h5>
<div class="form__select2">
<select class="js-select2 form__input form__input-lg" name="input-grant_type" id="input-grant_type">
<option selected value="tech">{% trans "Tech" %}</option>
<option value="media">{% trans "Media" %}</option>
<option value="health">{% trans "Public Health" %}</option>
<option value="community">{% trans "Community" %}</option>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the value should still be media

@thelostone-mc thelostone-mc merged commit 0f85a3b into gitcoinco:master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grant Categories Wrong On Grant Creation Page
2 participants