Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Grants Tweaks #6900

Merged
merged 5 commits into from
Jun 29, 2020
Merged

Conversation

developerfred
Copy link
Contributor

@developerfred developerfred commented Jun 16, 2020

Description

Fixes

Screen Shot 2020-06-16 at 20 13 13

Screen Shot 2020-06-16 at 20 12 35

Refers/Fixes

#6883

  • Change font color to Gitcoin green #25E899 to highlight the amount this round.
  • When I completed funding of a grant, this screen should have a button for me to fund another grant. I'm left here after tweeting about the grant.
  • Verifiy to Verify
  • Phone Number Modal
  • Phone number verification screen:
Testing

https://share.getcloudapp.com/4guj1pqe

@codecov
Copy link

codecov bot commented Jun 16, 2020

Codecov Report

Merging #6900 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6900      +/-   ##
==========================================
+ Coverage   26.49%   26.51%   +0.02%     
==========================================
  Files         298      298              
  Lines       28791    28791              
  Branches     4221     4221              
==========================================
+ Hits         7627     7633       +6     
+ Misses      20893    20887       -6     
  Partials      271      271              
Impacted Files Coverage Δ
app/dashboard/embed.py 31.60% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 982c990...d0421cf. Read the comment docs.

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few comments

@developerfred
Copy link
Contributor Author

done @thelostone-mc 👍

@danlipert
Copy link
Contributor

Hey @developerfred - you need to fill out the testing section of the PR description when you submit a PR - let me know if you dont understand this as I see a lot of PRs from you with this section blank

@developerfred
Copy link
Contributor Author

@danlipert Thank you for informing me that it is a priority field.

Copy link
Contributor

@danlipert danlipert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems the tweet ability needs to be re-added

@danlipert danlipert marked this pull request as draft June 24, 2020 12:45
@thelostone-mc thelostone-mc marked this pull request as ready for review June 25, 2020 12:34
@thelostone-mc thelostone-mc merged commit af2efa3 into gitcoinco:master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants