Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: Privacy Hackathon UX #6888

Merged
merged 2 commits into from
Jun 22, 2020
Merged

Conversation

developerfred
Copy link
Contributor

@developerfred developerfred commented Jun 16, 2020

Changes on This PR
  • odd issue with the format of the follow buttons on the hackathon page:

Now

Screen Shot 2020-06-16 at 04 57 39

old

https://gyazo.com/ba379f99e3cc54eb02ba57705fe8b73c

Now

  • Raiden and other logos show with a grey background for some reason:

Screen Shot 2020-06-16 at 04 58 13

old

https://gyazo.com/ba379f99e3cc54eb02ba57705fe8b73c

Now

  • images look fine on hackathon explorer but don't fit properly on each bounty page:

Screen Shot 2020-06-16 at 04 56 59

old

bounty page: https://gyazo.com/d6761beb8d392d1ae7847a053f8e714d

Refers/Fixes

#6878

Testing

@codecov
Copy link

codecov bot commented Jun 16, 2020

Codecov Report

Merging #6888 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6888      +/-   ##
==========================================
+ Coverage   26.93%   26.95%   +0.02%     
==========================================
  Files         297      297              
  Lines       28373    28373              
  Branches     4153     4153              
==========================================
+ Hits         7641     7647       +6     
+ Misses      20458    20452       -6     
  Partials      274      274              
Impacted Files Coverage Δ
app/dashboard/embed.py 31.60% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d898ef...1d331b7. Read the comment docs.

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@developerfred could we rebase ?
#6806 fixed it up in a diff way.
So i believe the index-vue changes won't be needed anymore

@developerfred
Copy link
Contributor Author

@thelostone-mc Thanks, I made the change.

@thelostone-mc thelostone-mc merged commit 9ea16bb into gitcoinco:master Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants