Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix token selection dropdown #6881

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Conversation

mds1
Copy link
Contributor

@mds1 mds1 commented Jun 15, 2020

Closes #6867

Changes:

  • Replaces select2 component :options parameter with <option> elements
  • Replaces underscores with emdashes for token divider (this centers the divider in its row instead of having it at the bottom)

To test:

  1. Add multiple grants to cart
  2. Remove one
  3. Make sure token selections do not change
  4. Change token selections of remaining grant check local storage > grants_cart
    and make sure the grant_donation_currency field is updated and matches what is in the token selection box

cc @owocki @apbendi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants