Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change pagination from 100 -> 10 for hackathon project response #6857

Merged
merged 5 commits into from
Jun 23, 2020

Conversation

androolloyd
Copy link
Contributor

fix for infinite scrolling on project directory

Description
Refers/Fixes
Testing

fix for infinite scrolling on project directory
@codecov
Copy link

codecov bot commented Jun 15, 2020

Codecov Report

Merging #6857 into master will not change coverage.
The diff coverage is 25.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6857   +/-   ##
=======================================
  Coverage   26.49%   26.49%           
=======================================
  Files         298      298           
  Lines       28791    28791           
  Branches     4221     4221           
=======================================
  Hits         7627     7627           
+ Misses      20893    20888    -5     
- Partials      271      276    +5     
Impacted Files Coverage Δ
app/dashboard/views.py 10.55% <0.00%> (ø)
app/dashboard/router.py 38.69% <100.00%> (ø)
app/quests/views.py 16.22% <0.00%> (ø)
...rketing/management/commands/no_applicants_email.py 0.00% <0.00%> (ø)
...eting/management/commands/assemble_leaderboards.py 39.73% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e5c005...afeb98c. Read the comment docs.

@thelostone-mc thelostone-mc changed the base branch from stable to master June 22, 2020 12:26
Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't tested but code lgtm

@danlipert danlipert merged commit 3a2dfbb into master Jun 23, 2020
@thelostone-mc thelostone-mc deleted the bugfix/hackathon-updates branch June 27, 2020 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants