Quests Table

[molecula451]

Description

#6718

Tables in Quest

Refers/Fixes

Testing

[molecula451]

Because I love the quest card style commented them out until further decision from the core-team. We cannot rely on the SVG loading and it's expensive in performance for the server as of now

[molecula451]

@thelostone-mc

[codecov]

Codecov Report

Merging #6808 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6808      +/-   ##
==========================================
+ Coverage   26.93%   26.95%   +0.02%     
==========================================
  Files         297      297              
  Lines       28373    28373              
  Branches     4153     4153              
==========================================
+ Hits         7641     7647       +6     
+ Misses      20458    20452       -6     
  Partials      274      274              

Impacted Files	Coverage Δ
app/dashboard/embed.py	31.60% <0.00%> (+3.44%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26fc384...940e8ae. Read the comment docs.

[owocki]

https://bits.owocki.com/Z4uYJp8d

just pulled this down, why are we using the space on the landing page so aggressively? IMHO there should only be one header row, we should move the "Play Quest" and "Play Time" elements to the rows, and reduce the padding between rows

[molecula451]

https://bits.owocki.com/Z4uYJp8d

just pulled this down, why are we using the space on the landing page so aggressively? IMHO there should only be one header row, we should move the "Play Quest" and "Play Time" elements to the rows, and reduce the padding between rows

Working things up! this one looks cleaner. I still need to add some layout data properties to make it ready. Please note the I've changed the "Play Quest" button with a Gamepad font icon

[owocki]

looking much better. i'd lose the glow on the header row. also lets make the columns align pls.

…

On Wed, Jun 10, 2020 at 9:50 PM Paul ***@***.***> wrote: https://bits.owocki.com/Z4uYJp8d just pulled this down, why are we using the space on the landing page so aggressively? IMHO there should only be one header row, we should move the "Play Quest" and "Play Time" elements to the rows, and reduce the padding between rows Working things up! this one looks cleaner. I still need to add some layout data properties to make it ready. Please note the I've changed the *"Play Quest"* button with a *Gamepad font icon* [image: quests] <https://user-images.githubusercontent.com/41552663/84343033-14666680-ab75-11ea-8c07-7748d9bb94c8.gif> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#6808 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAD5PCPFO7FVZPOIXMCTW6TRWBIBBANCNFSM4NZAHI6Q> .

-- @owocki <http://www.twitter.com/owocki>

_________________________________________ gitcoin is live and has generated over $4.6mm for Open Source Software - see our results <https://gitcoin.co/results>

[molecula451]

looking much better. i'd lose the glow on the header row. also lets make the columns align pls.

This is what is coming up!!

When in "Created" tab an "Ownership" row appear with link to edit quest
Quest change stage on Play row (cooldown, beaten, and unlocked to play)

[thelostone-mc]

Code looks alright !
@molecula451 could you remove the commented out code 🙌 should be lgtm otherwise

[molecula451]

Because I love the quest card style commented them out until further decision from the core-team. We cannot rely on the SVG loading and it's expensive in performance for the server as of now

@thelostone-mc Please refer the above. Unsure which decision you guys will take for the card style. Hiding them on toggle is probably an idea

[owocki]

i agree with removing the dead(commented) code. otherwise screenshots LGTM

[molecula451]

i agree with removing the dead(commented) code. otherwise screenshots LGTM

Purged dead code!

[molecula451]

Beaten quests

This is pretty much work done gentlemen

[molecula451]

purged card CSS

[PixelantDesign]

Is there a way to see what the quest is about before user clicks play?
showing the kudos a user would earn is exicitiing, I wonder if there is a way to work that in maybe on hover somewhere.

[molecula451]

Is there a way to see what the quest is about before user clicks play?
showing the kudos a user would earn is exicitiing, I wonder if there is a way to work that in maybe on hover somewhere.

Quest Name
Quest Prize

There is also a Description row

We cannot rely on the SVG. All SVG Are different in properties and it consumes a lot of the performance. Making the section inaccessible

[owocki]

@molecula451

checkout this screenshot: https://bits.owocki.com/xQuDqgY9

would you mind doing a follow up PR for a 0.25 ETH that

1. makes this mobile responsive
2. allows the user to hover a row (not just the play icon) and then click the whole row ?

[molecula451]

@molecula451

checkout this screenshot: https://bits.owocki.com/xQuDqgY9

would you mind doing a follow up PR for a 0.25 ETH that

1. makes this mobile responsive
2. allows the user to hover a row (not just the play icon) and then click the whole row ?

Sure thing @owocki will work things up today!