Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes embedded chat iframes that are not authorized. #6776

Merged

Conversation

androolloyd
Copy link
Contributor

Description

new global function chatSocketTest to detect if the user is connected to the chat server when they load an embedded iframe.

Refers/Fixes

#6580

Testing

Testing should be done on the /chat endpoint and any hackathon.

… try to access it through an iframe,

the user is returned to the location where they initiated the chat.
@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #6776 into feature/hackathon-updates-v1.1 will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                        Coverage Diff                         @@
##           feature/hackathon-updates-v1.1    #6776      +/-   ##
==================================================================
- Coverage                           26.69%   26.67%   -0.03%     
==================================================================
  Files                                 293      293              
  Lines                               27902    27880      -22     
  Branches                             4116     4113       -3     
==================================================================
- Hits                                 7449     7436      -13     
+ Misses                              20187    20178       -9     
  Partials                              266      266              
Impacted Files Coverage Δ
app/chat/tasks.py 14.01% <ø> (ø)
app/dashboard/views.py 10.69% <0.00%> (-0.10%) ⬇️
app/dashboard/models.py 49.28% <0.00%> (-0.04%) ⬇️
app/app/urls.py 86.20% <0.00%> (ø)
app/dashboard/admin.py 65.98% <0.00%> (+0.28%) ⬆️
app/dashboard/router.py 40.54% <0.00%> (+1.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 571b48f...1a913bc. Read the comment docs.

@androolloyd androolloyd changed the base branch from master to feature/hackathon-updates-v1.1 June 5, 2020 14:33
@androolloyd androolloyd merged commit b969f9a into feature/hackathon-updates-v1.1 Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant