Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only use a profiles most recent location to mark a location, for leaderboards #6772

Merged
merged 4 commits into from
Jun 22, 2020

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Jun 4, 2020

Description

only use a profiles most recent location to mark a location, for leaderboards

Refers/Fixes

https://gitcoin.co/leaderboard/countries?cadence=quarterly&keyword=all&product=all
why does the country list show prague still active in 2020? could it have anything to do with the fact that the entire ehtereum community was in prague in 2019? lol

Testing

tested locally

Copy link
Contributor

@PixelantDesign PixelantDesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me!

@thelostone-mc
Copy link
Member

@owocki looks like CI is failing !

@owocki
Copy link
Contributor Author

owocki commented Jun 5, 2020

just submited a fix

@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #6772 into master will increase coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6772   +/-   ##
=======================================
  Coverage   26.93%   26.93%           
=======================================
  Files         297      297           
  Lines       28373    28374    +1     
  Branches     4153     4154    +1     
=======================================
+ Hits         7641     7643    +2     
+ Misses      20458    20452    -6     
- Partials      274      279    +5     
Impacted Files Coverage Δ
...eting/management/commands/assemble_leaderboards.py 39.73% <50.00%> (-0.11%) ⬇️
app/dashboard/models.py 49.56% <100.00%> (+0.07%) ⬆️
app/quests/views.py 16.22% <0.00%> (ø)
app/dashboard/views.py 10.61% <0.00%> (ø)
...rketing/management/commands/no_applicants_email.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20a6574...5b22db6. Read the comment docs.

@danlipert danlipert merged commit 31f9afa into master Jun 22, 2020
@thelostone-mc thelostone-mc deleted the kevin/leaderboard_fix branch June 27, 2020 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants