Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed all wrong target "blank" to "_blank" #6763

Merged
merged 1 commit into from
Jun 4, 2020
Merged

Fixed all wrong target "blank" to "_blank" #6763

merged 1 commit into from
Jun 4, 2020

Conversation

Neurone
Copy link
Contributor

@Neurone Neurone commented Jun 3, 2020

Description

Using target="blank" opens links each time in the same window with name "blank". The intended behavior seems to be to create a new window for each link, so this PR fixes all wrong targets "blank" to "_blank".

Refers/Fixes

N.A.

Testing

This fixes only static HTML, no changes in test.

@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #6763 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6763      +/-   ##
==========================================
+ Coverage   26.67%   26.69%   +0.02%     
==========================================
  Files         293      293              
  Lines       27878    27878              
  Branches     4113     4113              
==========================================
+ Hits         7436     7442       +6     
+ Misses      20176    20170       -6     
  Partials      266      266              
Impacted Files Coverage Δ
app/dashboard/embed.py 31.60% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61844c9...8d7e403. Read the comment docs.

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@thelostone-mc thelostone-mc merged commit 6129577 into gitcoinco:master Jun 4, 2020
@gitcoinbot
Copy link
Member

⚡️ A tip worth 0.07000 ETH (17.03 USD @ $243.32/ETH) has been granted to @Neurone for this issue from @owocki. ⚡️

The sender had the following public comments:

ty for this!

Nice work @Neurone! Your tip has automatically been deposited in the ETH address we have on file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants