-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: Change email fix #6761
[BUG]: Change email fix #6761
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6761 +/- ##
==========================================
- Coverage 26.25% 26.23% -0.02%
==========================================
Files 300 300
Lines 29329 29323 -6
Branches 4319 4317 -2
==========================================
- Hits 7700 7693 -7
+ Misses 21358 21355 -3
- Partials 271 275 +4
Continue to review full report at Codecov.
|
@androolloyd you were unable to replicate the bug, correct? What convinces you that this is the correct fix? |
the issue was from a 500 error during the change, it happens when updating to an email in the master branch, you already used in the email marketing table, and lead me to the lines i changed. Once moving to an update or create, the error stops, and from what i can tell everything is operating as expected, i am able to change between any email associated to me. |
I was able to reproduce a 500 error and that error prevented me from updating my email address, there was a comment on a slack thread about a user getting a 500, once i saw that i investigated further as I had solved a 500 issue just moments before. |
Description
A 500 error occurs during email change, updated to use the update_or_create functionality of the Django orm to simplify the process.
Refers/Fixes
#6561