Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requests money form UX fixes #6760

Merged
merged 2 commits into from
Jun 4, 2020
Merged

requests money form UX fixes #6760

merged 2 commits into from
Jun 4, 2020

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Jun 3, 2020

Description
Refers/Fixes

requests money form UX fixes

  • prefill preferred payout addr
  • prevent ppl from requesting from self
  • force users to leave comment
  • easier to view request send from form

convos in slack with connor

Testing

tested locally

@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #6760 into master will increase coverage by 0.00%.
The diff coverage is 60.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6760   +/-   ##
=======================================
  Coverage   26.67%   26.67%           
=======================================
  Files         293      293           
  Lines       27878    27882    +4     
  Branches     4113     4113           
=======================================
+ Hits         7436     7438    +2     
+ Misses      20176    20173    -3     
- Partials      266      271    +5     
Impacted Files Coverage Δ
app/dashboard/tip_views.py 14.39% <ø> (ø)
app/dashboard/models.py 49.28% <60.00%> (+<0.01%) ⬆️
app/quests/views.py 16.22% <0.00%> (ø)
app/dashboard/views.py 10.70% <0.00%> (ø)
...rketing/management/commands/no_applicants_email.py 0.00% <0.00%> (ø)
...eting/management/commands/assemble_leaderboards.py 39.83% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61844c9...940f444. Read the comment docs.

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is for the payment reminder stuff right! nice

@thelostone-mc thelostone-mc merged commit 09d1331 into master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants