Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qrcode: wire in amount in qr string #6759

Merged
merged 5 commits into from
Jun 8, 2020
Merged

qrcode: wire in amount in qr string #6759

merged 5 commits into from
Jun 8, 2020

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Jun 3, 2020

Description
  • adds amount into qr code
  • capability to allow user to not include amount in QR
Refers/Fixes

Untitled

Testing
  • QR code tested in Trust wallet for ETC and it works
  • QR code works on Moonlet wallet

@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #6759 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6759   +/-   ##
=======================================
  Coverage   26.66%   26.66%           
=======================================
  Files         294      294           
  Lines       28118    28118           
  Branches     4135     4135           
=======================================
  Hits         7498     7498           
+ Misses      20354    20349    -5     
- Partials      266      271    +5     
Impacted Files Coverage Δ
app/quests/views.py 16.22% <0.00%> (ø)
app/dashboard/views.py 10.64% <0.00%> (ø)
...rketing/management/commands/no_applicants_email.py 0.00% <0.00%> (ø)
...eting/management/commands/assemble_leaderboards.py 39.83% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95de788...99aaf0c. Read the comment docs.

@thelostone-mc thelostone-mc marked this pull request as ready for review June 3, 2020 14:57
app/dashboard/templates/bounty/details2.html Outdated Show resolved Hide resolved
app/assets/v2/css/card.css Outdated Show resolved Hide resolved
@thelostone-mc thelostone-mc requested a review from octavioamu June 4, 2020 14:42
@danlipert danlipert merged commit 77126d1 into master Jun 8, 2020
@thelostone-mc thelostone-mc deleted the qr branch June 27, 2020 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants