Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change slack links to chat ones #6747

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Change slack links to chat ones #6747

merged 1 commit into from
Jun 2, 2020

Conversation

Solexplorer
Copy link
Contributor

Description

Changed links to redirect to chat instead of slack

Refers/Fixes
Testing

PR so small, are tests needed?

@codecov
Copy link

codecov bot commented Jun 1, 2020

Codecov Report

Merging #6747 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6747      +/-   ##
==========================================
+ Coverage   26.70%   26.72%   +0.02%     
==========================================
  Files         293      293              
  Lines       27845    27845              
  Branches     4108     4108              
==========================================
+ Hits         7435     7441       +6     
+ Misses      20139    20138       -1     
+ Partials      271      266       -5     
Impacted Files Coverage Δ
app/dashboard/notifications.py 17.15% <ø> (ø)
app/quests/views.py 16.22% <0.00%> (ø)
app/dashboard/views.py 10.78% <0.00%> (ø)
...rketing/management/commands/no_applicants_email.py 0.00% <0.00%> (ø)
...eting/management/commands/assemble_leaderboards.py 39.83% <0.00%> (ø)
app/dashboard/embed.py 31.60% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9332c88...105a765. Read the comment docs.

@thelostone-mc thelostone-mc merged commit ef470f9 into gitcoinco:master Jun 2, 2020
@danlipert
Copy link
Contributor

@Solexplorer just so you know, the testing section the PR doesn't require you to write tets, but rather just explain how it was tested - that could be via included unit tests, or you could just write that it doesnt need testing because its so simple, or the change isn't in the application itself, or you can add a video showing the results of your changes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants