re-enable free kudos for Gitcoin Quests/Grants #6745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owocki
requested review from
danlipert,
octavioamu and
thelostone-mc
as code owners
Codecov Report
@@ Coverage Diff @@
## master #6745 +/- ##
==========================================
+ Coverage 26.70% 27.62% +0.92%
==========================================
Files 293 294 +1
Lines 27845 29035 +1190
Branches 4108 4430 +322
==========================================
+ Hits 7435 8021 +586
- Misses 20144 20699 +555
- Partials 266 315 +49
Continue to review full report at Codecov.
|
danlipert
approved these changes
Jun 4, 2020
app/kudos/views.py
Outdated
| if profile.bulk_transfer_redemptions.filter(coupon=coupon).exists(): | ||
| error = f'You have already redeemed this kudos.' | ||
| return None, error, None | ||
| #if profile.bulk_transfer_redemptions.filter(coupon=coupon).exists(): |
There was a problem hiding this comment.
Do we actually want to remove this check or were these comments accidentally left in?
There was a problem hiding this comment.
Oh that should be there :P
thelostone-mc
approved these changes
Jun 4, 2020
thelostone-mc
requested review from
frankchen07 and
PixelantDesign
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few weeks ago, i noticed that with high gas prices on the eth network, the kudos minter was burning $200 per day in gas fees.
so i introduced a change to require people to pay their own gas, which would cut down the costs.
but following up on that today, it looks like this has really hurt the number of quest players, see below:
so i'm introducing this PR, which introduces a "not submitted" state to the kudos transfer object, wherein the kudos will be submitted to one's profile immediately, but not to their web3 wallet until the ethereum network isnt super expensive anymore.
hopefully this approach reaches the twin goal of keeping gitcoin's costs down AND also keeping quest usage up
from testing:
