Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2/n: fiat integration #6710

Merged
merged 2 commits into from
May 27, 2020
Merged

2/n: fiat integration #6710

merged 2 commits into from
May 27, 2020

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented May 25, 2020

Description
  • remove standard bounties code from details2
  • Alter BountyFulfillment fields to allow null values
  • bounty creation: add fiat support showing alert + hiding token
  • start work: add disclaimer notifying contributor that payment is via Paypal
  • submit work: hide blockchain text + hide wallet address & ask paypal email id
  • payout: add new payout flow for fiat payments
  • add new activity called worker_paid so that activity is cleaner
Demo
Flows Tested
  • ETH bounty
  • QR code bounty
  • fiat bounty

@thelostone-mc thelostone-mc force-pushed the backend branch 2 times, most recently from acdef2a to e3ae484 Compare May 26, 2020 12:34
@thelostone-mc thelostone-mc marked this pull request as ready for review May 26, 2020 12:34
@thelostone-mc thelostone-mc requested a review from androolloyd May 27, 2020 06:57
- remove standard bounties code from details2
- Alter BountyFulfillment fields to allow null values
- bounty creation: add fiat support showing alert + hiding token
- start work: add disclaimer notifying contributor that payment is via Paypal
- submit work: hide blockchain text + hide wallet address & ask paypal email id
- payout: add new payout flow for fiat payments
- add new activity called worker_paid so that activity is cleaner
@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #6710 into master will decrease coverage by 0.03%.
The diff coverage is 12.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6710      +/-   ##
==========================================
- Coverage   26.70%   26.67%   -0.04%     
==========================================
  Files         293      293              
  Lines       27589    27670      +81     
  Branches     4073     4090      +17     
==========================================
+ Hits         7367     7380      +13     
- Misses      19957    20025      +68     
  Partials      265      265              
Impacted Files Coverage Δ
app/dashboard/helpers.py 14.25% <ø> (ø)
app/dashboard/router.py 40.89% <ø> (ø)
app/marketing/mails.py 11.32% <ø> (ø)
app/dashboard/views.py 10.73% <1.85%> (-0.20%) ⬇️
app/dashboard/sync/helpers.py 27.27% <25.00%> (-39.40%) ⬇️
app/dashboard/sync/celo.py 14.28% <50.00%> (-0.35%) ⬇️
app/dashboard/sync/etc.py 14.28% <50.00%> (-0.35%) ⬇️
app/dashboard/sync/zil.py 20.00% <50.00%> (-0.46%) ⬇️
app/app/settings.py 82.14% <100.00%> (+0.05%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d92093f...5992e61. Read the comment docs.

@thelostone-mc thelostone-mc merged commit 00b19c4 into gitcoinco:master May 27, 2020
@owocki
Copy link
Contributor

owocki commented May 27, 2020

wait so this is in the release!??!?! does that mean USD bounties are now a possibility? shouldwe put behind a staff/alpha flag?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants