Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matic whitelabel grant creation and index #6709

Merged
merged 2 commits into from
May 27, 2020
Merged

Conversation

danlipert
Copy link
Contributor

Description

This PR adds a whitelabeled grants creation page for Matic

Refers/Fixes

n/a

Testing

Tested locally

screencapture-localhost-8000-grants-matic-new-2020-05-25-21_19_12

screencapture-localhost-8000-grants-2020-05-25-21_36_42

@thelostone-mc
Copy link
Member

@danlipert I assume this is throwaway code once the grant round is over ?

@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #6709 into master will decrease coverage by 0.00%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6709      +/-   ##
==========================================
- Coverage   26.73%   26.73%   -0.01%     
==========================================
  Files         293      293              
  Lines       27533    27537       +4     
  Branches     4069     4069              
==========================================
+ Hits         7361     7362       +1     
+ Misses      19907    19905       -2     
- Partials      265      270       +5     
Impacted Files Coverage Δ
app/grants/models.py 49.35% <ø> (ø)
app/grants/urls.py 100.00% <ø> (ø)
app/grants/views.py 16.44% <25.00%> (+0.05%) ⬆️
app/quests/views.py 16.22% <0.00%> (ø)
app/dashboard/views.py 10.92% <0.00%> (ø)
...rketing/management/commands/no_applicants_email.py 0.00% <0.00%> (ø)
...eting/management/commands/assemble_leaderboards.py 40.05% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 227f78a...7cce34f. Read the comment docs.

@thelostone-mc thelostone-mc merged commit d92093f into master May 27, 2020
@SumitShinde1
Copy link

Hi, I'm from Matic team.
Can we make few changes in the messaging so that it is consistent throughout the user journey? I'm anticipating that users will come to this registration form from the CTA that's linked on the marketing landing page.

The message on the website (Link to the staging site https://matic.today/build-n-earn/) is
"Apply for Matic Build-n-Earn Program for technical, business & investment support"
CTA - Register your DApp

Can we keep the CTA consistent?

  1. So replacing "Create a grant" from everywhere to "Register your DApp"
  2. Reduce the size of Matic Logo and write a name of this initiative i.e., "Matic(logo) Build-n-Earn Program"
  3. Do we have option to link back to Matic Build-n-Earn page from here?

@danlipert
Copy link
Contributor Author

Hey @SumitShinde1 - I've got a V2 PR up at #6753 - check it out and let me know what you think

@thelostone-mc thelostone-mc deleted the matic-new-grants branch June 27, 2020 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants