Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifs #6704

Merged
merged 1 commit into from
Jun 8, 2020
Merged

Notifs #6704

merged 1 commit into from
Jun 8, 2020

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented May 23, 2020

Description

  • Wire in GitHub notification for cross-chain

Q: not clear on when the email + GitHub notification + activity should be created for payout flow
Is it each time when funder pays out / when the funder closes the bounty -> just 1 update ?

In other words should these be be in close_bounty_v1 or should it be in payout_bounty_v1
I think it's correct the way it is but wanted to double check

Refers/Fixes
Testing

NOT TESTED

@thelostone-mc thelostone-mc changed the base branch from master to stable May 23, 2020 10:02
@codecov
Copy link

codecov bot commented May 23, 2020

Codecov Report

Merging #6704 into stable will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           stable    #6704      +/-   ##
==========================================
- Coverage   27.12%   27.11%   -0.02%     
==========================================
  Files         292      292              
  Lines       27149    27164      +15     
  Branches     3990     3994       +4     
==========================================
  Hits         7365     7365              
- Misses      19514    19524      +10     
- Partials      270      275       +5     
Impacted Files Coverage Δ
app/dashboard/utils.py 40.70% <0.00%> (-0.62%) ⬇️
app/dashboard/views.py 10.90% <0.00%> (-0.03%) ⬇️
app/quests/views.py 16.22% <0.00%> (ø)
...rketing/management/commands/no_applicants_email.py 0.00% <0.00%> (ø)
...eting/management/commands/assemble_leaderboards.py 40.05% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5e0a9c...08e78e9. Read the comment docs.

@danlipert
Copy link
Contributor

danlipert commented Jun 8, 2020

I'm thinking once the bounty is closed is probably best, but either way is fine

@danlipert danlipert merged commit be0f3e0 into stable Jun 8, 2020
@thelostone-mc thelostone-mc deleted the notifs branch June 27, 2020 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants