Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Grant import to townsquare/utils #6693

Merged
merged 1 commit into from
May 21, 2020

Conversation

androolloyd
Copy link
Contributor

Description

townsquare/utils has a helper can_pin to check for permission to create/update/delete a pin, the grant import was missing.

Refers/Fixes

Bug found by @owocki

Testing

@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #6693 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6693   +/-   ##
=======================================
  Coverage   27.12%   27.12%           
=======================================
  Files         291      291           
  Lines       27115    27115           
  Branches     3989     3989           
=======================================
  Hits         7354     7354           
+ Misses      19493    19488    -5     
- Partials      268      273    +5     
Impacted Files Coverage Δ
app/townsquare/views.py 9.86% <ø> (-0.20%) ⬇️
app/townsquare/utils.py 18.18% <100.00%> (+2.55%) ⬆️
app/quests/views.py 16.22% <0.00%> (ø)
app/dashboard/views.py 10.93% <0.00%> (ø)
...rketing/management/commands/no_applicants_email.py 0.00% <0.00%> (ø)
...eting/management/commands/assemble_leaderboards.py 40.05% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7df6d5a...8a2e4f1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants