Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wait for web3 to be unlocked before calling waitforweb3 #6684

Merged
merged 2 commits into from
May 20, 2020

Conversation

owocki
Copy link
Contributor

@owocki owocki commented May 20, 2020

Description

wait for web3 to be unlocked before calling waitforweb3

Refers/Fixes

https://gitcoincore.slack.com/archives/CAXQ7PT60/p1589942927310200?thread_ts=1589898355.303800&cid=CAXQ7PT60

Testing

have not tested at all, raising this for aditya to test per his request

@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #6684 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6684   +/-   ##
=======================================
  Coverage   27.13%   27.13%           
=======================================
  Files         291      291           
  Lines       27033    27033           
  Branches     3979     3979           
=======================================
  Hits         7335     7335           
+ Misses      19430    19425    -5     
- Partials      268      273    +5     
Impacted Files Coverage Δ
app/quests/views.py 16.22% <0.00%> (ø)
app/dashboard/views.py 10.98% <0.00%> (ø)
...rketing/management/commands/no_applicants_email.py 0.00% <0.00%> (ø)
...eting/management/commands/assemble_leaderboards.py 40.05% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3446cd...5ef570b. Read the comment docs.

@octavioamu octavioamu merged commit 28f6ad6 into master May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants