Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loading tokens indicator #6681

Merged
merged 2 commits into from
May 20, 2020
Merged

loading tokens indicator #6681

merged 2 commits into from
May 20, 2020

Conversation

owocki
Copy link
Contributor

@owocki owocki commented May 19, 2020

Description

im tired of answering questions from people about why DAI, or other tokens, arent showing up in their token dropdowns
here is a mock of a simple indicator that the token list is drawn from your web3 wallet. it can probably be improved
slack-imgs

Refers/Fixes

https://gitcoincore.slack.com/archives/CAW05FUD7/p1589892852270300

Testing

tested locally

@codecov
Copy link

codecov bot commented May 19, 2020

Codecov Report

Merging #6681 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6681      +/-   ##
==========================================
- Coverage   27.13%   27.09%   -0.05%     
==========================================
  Files         291      291              
  Lines       27050    27039      -11     
  Branches     3982     3983       +1     
==========================================
- Hits         7339     7325      -14     
+ Misses      19443    19442       -1     
- Partials      268      272       +4     
Impacted Files Coverage Δ
app/dashboard/embed.py 28.16% <0.00%> (-3.45%) ⬇️
app/dashboard/router.py 40.48% <0.00%> (-0.41%) ⬇️
app/dashboard/admin.py 57.96% <0.00%> (-0.12%) ⬇️
app/dashboard/models.py 50.35% <0.00%> (-0.10%) ⬇️
app/dashboard/helpers.py 14.19% <0.00%> (-0.07%) ⬇️
app/retail/emails.py 22.41% <0.00%> (-0.04%) ⬇️
...rketing/management/commands/no_applicants_email.py 0.00% <0.00%> (ø)
...eting/management/commands/assemble_leaderboards.py 40.05% <0.00%> (ø)
app/dashboard/views.py 11.04% <0.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b719bf...0818906. Read the comment docs.

@thelostone-mc thelostone-mc merged commit 515ec4e into master May 20, 2020
@thelostone-mc thelostone-mc deleted the kevin/load_tokens_item branch June 27, 2020 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants