Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to Open Response and link single poll to multiple hackathons #6669

Merged
merged 8 commits into from
May 20, 2020

Conversation

zoek1
Copy link
Contributor

@zoek1 zoek1 commented May 18, 2020

Description
  • open question format
  • multiple questions per poll
  • nicely designed HTMLS from will
Refers/Fixes

#6682

Testing

https://www.loom.com/share/8e45d7b501bb4ee28a11302434ae2ece

image

image

@zoek1 zoek1 marked this pull request as ready for review May 19, 2020 01:42
@thelostone-mc
Copy link
Member

@zoek1 which issue does this map to github ?

@zoek1
Copy link
Contributor Author

zoek1 commented May 19, 2020

No issue related, @frankchen07 could you create the issue?

@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #6669 into master will increase coverage by 0.01%.
The diff coverage is 30.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6669      +/-   ##
==========================================
+ Coverage   27.09%   27.10%   +0.01%     
==========================================
  Files         291      291              
  Lines       27039    27048       +9     
  Branches     3983     3985       +2     
==========================================
+ Hits         7325     7332       +7     
- Misses      19446    19448       +2     
  Partials      268      268              
Impacted Files Coverage Δ
app/dashboard/views.py 11.01% <0.00%> (-0.04%) ⬇️
app/dashboard/admin.py 57.85% <100.00%> (-0.12%) ⬇️
app/dashboard/models.py 50.39% <100.00%> (+0.03%) ⬆️
app/dashboard/embed.py 31.60% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f48c205...290b71f. Read the comment docs.

Copy link
Contributor

@danlipert danlipert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work @zoek1 !

@thelostone-mc thelostone-mc merged commit 3fa0e43 into gitcoinco:master May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants