Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1/n : fiat support - model changes #6668

Merged
merged 1 commit into from
May 20, 2020

Conversation

thelostone-mc
Copy link
Member

Description
  • added modal changes needed to support fiat
  • added help text for bounty fulfillments
  • added custom migration to update existing data for newly added fields
  • added TODO comments to alter fields name for later

Fields added:

Field Description
payout_type fiat / qr / standard_bounties
tenant each payout_type has it's unique set on tenants Eg: celo for qr bounties / pypl for fiat
funder_address same as bounty_owner_address but will be updated later on for shared mgmt
funder_profile same as bounty_owner_profile but will be updated later on for shared mgmt
funder_identifier unique funder identifier in fiat flow (like pypl username)
fulfiller_identifier unique fulfiller identifier for when (like pypl username)
Testing
  • std bounties flow (creation -> fulfillment -> payout)
  • cross chain flow (creation -> fulfillment -> payout)
  • ran custom migration to udpate exsisting db

Screenshot 2020-05-16 at 7 55 37 PM

Screenshot 2020-05-16 at 7 55 44 PM

======

Screenshot 2020-05-17 at 9 59 34 AM

Screenshot 2020-05-17 at 9 59 28 AM

@thelostone-mc thelostone-mc force-pushed the model_changes branch 2 times, most recently from f8b1f4e to f1fd9cb Compare May 17, 2020 05:18
Copy link
Contributor

@danlipert danlipert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a few suggestions

app/dashboard/models.py Outdated Show resolved Hide resolved
app/dashboard/migrations/0110_auto_20200517_0514.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

Merging #6668 into master will increase coverage by 0.03%.
The diff coverage is 61.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6668      +/-   ##
==========================================
+ Coverage   27.09%   27.12%   +0.03%     
==========================================
  Files         291      291              
  Lines       27039    27059      +20     
  Branches     3983     3985       +2     
==========================================
+ Hits         7325     7339      +14     
- Misses      19446    19452       +6     
  Partials      268      268              
Impacted Files Coverage Δ
app/dashboard/helpers.py 14.19% <ø> (ø)
app/dashboard/views.py 10.99% <0.00%> (-0.06%) ⬇️
app/dashboard/models.py 50.50% <100.00%> (+0.14%) ⬆️
app/dashboard/embed.py 31.60% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f48c205...acedbc1. Read the comment docs.

@thelostone-mc thelostone-mc merged commit 1e2d273 into gitcoinco:master May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants