improvement(dark mode): more tag, input and alert styles #6666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelonye
requested review from
danlipert,
octavioamu and
thelostone-mc
as code owners
|
|
|
Alert state styles might need further improvements:
|
kelonye
changed the title
|
looks good to me! |
|
these screenshots look really good! |
|
@vbstreetz looks like CI is failing! Could you make sure -> CI passes in the upcoming PRs ? I'll fix it up for now |
thelostone-mc
approved these changes
May 20, 2020
Codecov Report
@@ Coverage Diff @@
## master #6666 +/- ##
==========================================
+ Coverage 27.13% 27.15% +0.02%
==========================================
Files 291 291
Lines 27033 27033
Branches 3979 3979
==========================================
+ Hits 7335 7341 +6
+ Misses 19430 19424 -6
Partials 268 268
Continue to review full report at Codecov.
|
danlipert
approved these changes
May 20, 2020
octavioamu
approved these changes
May 20, 2020
|
@thelostone-mc sure! hopefully prettier gets integrated soon as well.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some additional dark mode fixes
Time logged: 2 hrs
Description
Refers/Fixes
Closes #6631
Testing
N/A