Combine Start Work & Project Creation Forms #6661
Conversation
zoek1
requested review from
danlipert,
octavioamu and
thelostone-mc
as code owners
zoek1
changed the title
zoek1
changed the title
|
Looking good! Could we see a video of the form working? |
Codecov Report
@@ Coverage Diff @@
## master #6661 +/- ##
==========================================
+ Coverage 26.67% 26.69% +0.02%
==========================================
Files 293 293
Lines 27878 27889 +11
Branches 4113 4114 +1
==========================================
+ Hits 7436 7445 +9
- Misses 20176 20178 +2
Partials 266 266
Continue to review full report at Codecov.
|
|
@zoek1 could you throw in video to help @PixelantDesign validate the flow ? |
|
I just posted the video demo in the descriptions @PixelantDesign @thelostone-mc :) |
|
looks great! |
|
@alexvotofuture @connoroday what do you think? |
|
Awesome, @zoek1. Looks like it functions exactly as we expected. Thank you for the work on this! |
| let logo = $(this)[0]['logo'].files[0]; | ||
| let data = $(this).serializeArray(); | ||
|
|
||
| submitInterest(document.result['pk'], '', self, () => { |
There was a problem hiding this comment.
I believe this will be an empty interest on the activity.
There was a problem hiding this comment.
Replaced the empty string with the project description
| @@ -601,7 +601,12 @@ var show_interest_modal = function() { | |||
| modalBody.load(modalUrl, ()=> { | |||
| let actionPlanForm = $('#action_plan'); | |||
| let issueMessage = $('#issue_message'); | |||
| let data = $('.team-users').data('initial') ? $('.team-users').data('initial').split(', ') : []; | |||
There was a problem hiding this comment.
I believe this is missing the projects changes for ETC bounties
There was a problem hiding this comment.
|
@zoek once you address @octavioamu comments ~ Could you throw in a demo for hackathons bounty creation flow for ETC |
…into feature/project-modal
|
Thanks for the video @zoek1! I see the ETC bounty there! |
| @@ -4716,6 +4716,7 @@ class HackathonProject(SuperModel): | |||
| ) | |||
| looking_members = models.BooleanField(default=False) | |||
| chat_channel_id = models.CharField(max_length=255, blank=True, null=True) | |||
| extra = JSONField(default=dict, blank=True, null=True) | |||
There was a problem hiding this comment.
could you add in helpt text to explain this better In a follow up PR
| let logo = elements['logo'].files[0]; | ||
| let summary = elements['summary'].value; | ||
| let data = $(this).serializeArray(); | ||
|
|
Description
On looking for a skill, we should pre populate the tags that we use on the funder form (front end, backend, design, etc)
until you submit work
DEMO:
https://www.loom.com/share/430a1a6963ee487ab4f3c580d5b6c64d
Refers/Fixes
#6444
Testing
ETC bounties
https://www.loom.com/share/d68910dfeadd4c7b9858aff2419358ee