Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove animation #6658

Merged
merged 1 commit into from
May 14, 2020
Merged

Conversation

thelostone-mc
Copy link
Member

Description

remove rain which causes screen to scroll on its own during waiting screen

@codecov
Copy link

codecov bot commented May 14, 2020

Codecov Report

Merging #6658 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6658      +/-   ##
==========================================
+ Coverage   27.13%   27.15%   +0.02%     
==========================================
  Files         291      291              
  Lines       26959    26959              
  Branches     3974     3974              
==========================================
+ Hits         7316     7322       +6     
+ Misses      19371    19369       -2     
+ Partials      272      268       -4     
Impacted Files Coverage Δ
app/dashboard/views.py 11.05% <0.00%> (ø)
...rketing/management/commands/no_applicants_email.py 0.00% <0.00%> (ø)
...eting/management/commands/assemble_leaderboards.py 40.05% <0.00%> (ø)
app/dashboard/embed.py 31.60% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 144365c...fe7f341. Read the comment docs.

@thelostone-mc thelostone-mc merged commit c4bf765 into gitcoinco:master May 14, 2020
@owocki
Copy link
Contributor

owocki commented May 15, 2020

this PR makes makes the product more bland & lame.

why not just add some CSS such that it doesnt scroll on this one page where its a problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants