purge: gas settings #6656
purge: gas settings #6656
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6656 +/- ##
==========================================
+ Coverage 27.09% 27.13% +0.04%
==========================================
Files 291 291
Lines 27039 27009 -30
Branches 3983 3978 -5
==========================================
+ Hits 7325 7330 +5
+ Misses 19446 19411 -35
Partials 268 268
Continue to review full report at Codecov.
|
thelostone-mc
force-pushed
the
purge
branch
3 times, most recently
from
42873eb to
9314fb6
Compare
There was a problem hiding this comment.
looks good - has some unrelated fixes/changes which is fine but you should note them in the PR description. Also, instead of commenting out code, lets just delete it! If that is too scary, then put the deleted code in a separate commit and then squash the PR down to 2 commits. Then you can just revert the deletion if you want it back - much cleaner!
| @@ -149,21 +149,6 @@ const init = () => { | |||
| // trusted relayer | |||
| web3.utils.toChecksumAddress(data.trusted_relayer) | |||
| ]; | |||
| } else if ($('#contract_version').val() == 0) { | |||
There was a problem hiding this comment.
Ready to retire the v0 deploy? I think I'm cool with it...
There was a problem hiding this comment.
YASS! Update the PR description as well
Description
Flows tested