Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set description and image for SEO #6652

Merged
merged 3 commits into from
May 27, 2020
Merged

Conversation

x5engine
Copy link
Contributor

Set description and image for SEO (twitter and facebook...)

PR fix for #6645

Set description and image for SEO (twitter and facebook...)
@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #6652 into master will increase coverage by 8.83%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6652      +/-   ##
==========================================
+ Coverage   18.32%   27.15%   +8.83%     
==========================================
  Files         282      291       +9     
  Lines       27455    26961     -494     
  Branches     4065     3974      -91     
==========================================
+ Hits         5031     7322    +2291     
+ Misses      22412    19371    -3041     
- Partials       12      268     +256     
Impacted Files Coverage Δ
app/dashboard/views.py 11.04% <0.00%> (+2.53%) ⬆️
app/townsquare/admin.py 37.50% <0.00%> (-2.50%) ⬇️
app/kudos/tasks.py 26.38% <0.00%> (-1.01%) ⬇️
app/quests/models.py 42.16% <0.00%> (-0.70%) ⬇️
app/townsquare/models.py 57.70% <0.00%> (-0.70%) ⬇️
app/dashboard/router.py 40.48% <0.00%> (-0.41%) ⬇️
app/retail/views.py 21.79% <0.00%> (-0.24%) ⬇️
app/app/context.py 0.00% <0.00%> (ø)
app/quests/management/commands/re_rank_quests.py 0.00% <0.00%> (ø)
...pp/dashboard/management/commands/send_bulk_tips.py 0.00% <0.00%> (ø)
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e869117...e0b8761. Read the comment docs.

@thelostone-mc
Copy link
Member

@x5engine would you be able to throw in a screenshot please?

@x5engine
Copy link
Contributor Author

@thelostone-mc for this one I can't since I didn't get the docker image running on windows :'( help and I'll knock any bugs like flies, mosquitos and so on.

@danlipert
Copy link
Contributor

@x5engine not sure why you are having issues on windows - maybe try setting up a ubuntu VM? Since you didn't get this running, I'm assuming this is untested?

@danlipert danlipert marked this pull request as draft May 18, 2020 12:41
@x5engine
Copy link
Contributor Author

Untested but 90% working

@thelostone-mc thelostone-mc marked this pull request as ready for review May 27, 2020 07:56
@thelostone-mc
Copy link
Member

thelostone-mc commented May 27, 2020

locally seems to work !

@thelostone-mc thelostone-mc merged commit 3cb28d1 into gitcoinco:master May 27, 2020
@x5engine
Copy link
Contributor Author

It works! Would fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants