limit maximum input in the comments 500 chars #6641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limit maximum input in the comments otherwise, you will get something like this https://gitcoin.co/townsquare?tab=activity:273525
x5engine
requested review from
danlipert,
octavioamu and
thelostone-mc
as code owners
Codecov Report
@@ Coverage Diff @@
## master #6641 +/- ##
==========================================
+ Coverage 27.22% 27.24% +0.02%
==========================================
Files 288 288
Lines 26891 26891
Branches 3968 3968
==========================================
+ Hits 7320 7326 +6
+ Misses 19303 19297 -6
Partials 268 268
Continue to review full report at Codecov.
|
thelostone-mc
approved these changes
May 13, 2020
|
yeaah but where is my 1 eth :D @thelostone-mc jk :P |
|
okay then it means, I get nothing for contributing? |
|
did you read the above monetization policy |
|
okay sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
limit maximum input in the comments otherwise, you will get something like this
https://gitcoin.co/townsquare?tab=activity:273525
so better allow maximum 500 chararacters