Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No contrib grants clr fix #6602

Merged
merged 1 commit into from
May 6, 2020
Merged

Conversation

danlipert
Copy link
Contributor

Description

this PR fixes a divide by zero error where the normalization factor could not be calculated during CLR

Refers/Fixes

n/a

Testing

not tested

@danlipert danlipert changed the base branch from master to stable May 6, 2020 15:56
@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #6602 into stable will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           stable    #6602      +/-   ##
==========================================
- Coverage   27.22%   27.22%   -0.01%     
==========================================
  Files         288      288              
  Lines       26865    26866       +1     
  Branches     3965     3966       +1     
==========================================
  Hits         7313     7313              
+ Misses      19284    19281       -3     
- Partials      268      272       +4     
Impacted Files Coverage Δ
app/grants/clr.py 13.19% <0.00%> (-0.06%) ⬇️
app/dashboard/views.py 11.05% <0.00%> (ø)
...rketing/management/commands/no_applicants_email.py 0.00% <0.00%> (ø)
...eting/management/commands/assemble_leaderboards.py 40.48% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7c7a8a...c727e81. Read the comment docs.

@thelostone-mc thelostone-mc merged commit 527a4cf into stable May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants