Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add projects responsive fixes #6563

Conversation

zoek1
Copy link
Contributor

@zoek1 zoek1 commented May 1, 2020

Description

image

Refers/Fixes
Testing

@thelostone-mc
Copy link
Member

thelostone-mc commented May 3, 2020

@zoek1 conflicts :P

@zoek1 zoek1 force-pushed the feature/projects-responsive branch from cbfb0ae to f49dc0b Compare May 4, 2020 02:46
@zoek1 zoek1 changed the base branch from feature/tribes-ts to feature/tribes-ts-updates May 4, 2020 02:46
@zoek1 zoek1 changed the base branch from feature/tribes-ts-updates to master May 4, 2020 02:48
@zoek1 zoek1 changed the base branch from master to feature/tribes-ts-updates May 4, 2020 02:48
@codecov
Copy link

codecov bot commented May 4, 2020

Codecov Report

Merging #6563 into feature/tribes-ts-updates will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@                      Coverage Diff                      @@
##           feature/tribes-ts-updates    #6563      +/-   ##
=============================================================
+ Coverage                      27.23%   27.26%   +0.02%     
=============================================================
  Files                            288      288              
  Lines                          26826    26826              
  Branches                        3960     3960              
=============================================================
+ Hits                            7307     7313       +6     
+ Misses                         19247    19245       -2     
+ Partials                         272      268       -4     
Impacted Files Coverage Δ
app/dashboard/views.py 11.06% <0.00%> (ø)
...rketing/management/commands/no_applicants_email.py 0.00% <0.00%> (ø)
...eting/management/commands/assemble_leaderboards.py 40.48% <0.00%> (ø)
app/dashboard/embed.py 31.60% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9864aff...fe4b1c5. Read the comment docs.

@zoek1 zoek1 force-pushed the feature/projects-responsive branch from f49dc0b to cac1d2b Compare May 4, 2020 03:47
@PixelantDesign
Copy link
Contributor

Looks pretty good! The Gitcoin logo is squished in the upper left hand corner. Is that just the screenshot? @zoek1

@androolloyd androolloyd force-pushed the feature/tribes-ts-updates branch from a876453 to fe5eca2 Compare May 4, 2020 14:00
@androolloyd
Copy link
Contributor

@zoek1 can you resolve conflicts plz

@zoek1 zoek1 force-pushed the feature/projects-responsive branch from 4ec8a2b to d369376 Compare May 4, 2020 18:53
@androolloyd androolloyd merged commit 1b6e8f4 into gitcoinco:feature/tribes-ts-updates May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants