Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes weekly email #6534

Merged
merged 13 commits into from
May 1, 2020
Merged

Conversation

sebastiantf
Copy link
Contributor

@sebastiantf sebastiantf commented Apr 30, 2020

Description

Fixes issues with Weekly Email not being rendered properly on email clients.

Follow-up to #6438

Refers/Fixes
Testing

Before:
weekly_issues

weekly_issues2

After:

Gmail Web:
weekly_fixed_gmail_web

Gmail Mobile:
weekly_fixed_gmail_android

@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #6534 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6534      +/-   ##
==========================================
- Coverage   27.30%   27.29%   -0.01%     
==========================================
  Files         287      287              
  Lines       26801    26720      -81     
  Branches     3962     3946      -16     
==========================================
- Hits         7317     7294      -23     
+ Misses      19216    19159      -57     
+ Partials      268      267       -1     
Impacted Files Coverage Δ
app/dashboard/router.py 36.04% <0.00%> (-4.03%) ⬇️
app/dashboard/models.py 50.26% <0.00%> (-0.04%) ⬇️
app/dashboard/views.py 11.12% <0.00%> (+0.08%) ⬆️
app/dashboard/embed.py 31.60% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86b0c46...e0d57fb. Read the comment docs.

@sebastiantf sebastiantf marked this pull request as ready for review April 30, 2020 16:41
@sebastiantf sebastiantf force-pushed the fixes-weekly-email branch from 00b0d73 to 3d3af26 Compare May 1, 2020 11:48
@thelostone-mc thelostone-mc merged commit ea9071e into gitcoinco:master May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants