Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cross: redo payout flow #6524

Merged
merged 2 commits into from
Apr 29, 2020
Merged

cross: redo payout flow #6524

merged 2 commits into from
Apr 29, 2020

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Apr 29, 2020

Description

  • redo payout screen based on new mock
  • makes payout a 3 step process with clearer steps
  • update backend to handle when txn id is submitted
Testing
  1. UI flow
    Untitled

  2. paying out with txn id

Untitled

  1. paying out with QR Code

Untitled

@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #6524 into master will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6524      +/-   ##
==========================================
+ Coverage   27.07%   27.09%   +0.01%     
==========================================
  Files         291      291              
  Lines       26682    26685       +3     
  Branches     3948     3949       +1     
==========================================
+ Hits         7223     7229       +6     
+ Misses      19192    19189       -3     
  Partials      267      267              
Impacted Files Coverage Δ
app/dashboard/sync/etc.py 14.63% <ø> (ø)
app/dashboard/views.py 11.22% <0.00%> (-0.02%) ⬇️
app/retail/emails.py 22.34% <0.00%> (ø)
app/dashboard/embed.py 31.60% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59935a3...32d6240. Read the comment docs.

@thelostone-mc thelostone-mc marked this pull request as ready for review April 29, 2020 04:27
@danlipert danlipert merged commit ae77056 into gitcoinco:master Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants