Change Quest selected option button color to green for better UI #6522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastiantf
requested review from
danlipert,
octavioamu and
thelostone-mc
as code owners
sebastiantf
changed the title
Codecov Report
@@ Coverage Diff @@
## master #6522 +/- ##
==========================================
+ Coverage 27.26% 27.29% +0.02%
==========================================
Files 287 287
Lines 26712 26712
Branches 3945 3945
==========================================
+ Hits 7284 7290 +6
+ Misses 19161 19155 -6
Partials 267 267
Continue to review full report at Codecov.
|
sebastiantf
force-pushed
the
change-selected-button-color
branch
from
b7c9e88 to
f2d232e
Compare
|
@owocki Please let me know of any changes or suggestions. To refer to the images/backgrounds, start from 0-33 and then blue, green, red in the end. (or maybe repost the image 🤷♂️) |
sebastiantf
force-pushed
the
change-selected-button-color
branch
from
f2d232e to
b593f82
Compare
octavioamu
approved these changes
Apr 29, 2020
|
The screenshots <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the selected option button color on Quests.
Refers/Fixes
Fixes #6517
Screenshots
Without any options selected:
With options selected and/or hovered: