Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add confirmation to migrate_grant #6508

Merged
merged 2 commits into from
Apr 29, 2020

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Apr 27, 2020

Description
  • adds in confirmation before migrating grants over
  • remove the old_scripts

Screenshot 2020-04-27 at 6 02 34 AM

@thelostone-mc thelostone-mc changed the title add confirmation to migrate_grant. remove old script chore: add confirmation to migrate_grant Apr 27, 2020
@codecov
Copy link

codecov bot commented Apr 27, 2020

Codecov Report

Merging #6508 into master will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6508      +/-   ##
==========================================
+ Coverage   27.06%   27.09%   +0.02%     
==========================================
  Files         291      291              
  Lines       26685    26685              
  Branches     3949     3949              
==========================================
+ Hits         7223     7229       +6     
+ Misses      19195    19189       -6     
  Partials      267      267              
Impacted Files Coverage Δ
app/grants/management/commands/migrate_grant.py 0.00% <0.00%> (ø)
app/retail/emails.py 22.34% <0.00%> (ø)
app/dashboard/sync/etc.py 14.63% <0.00%> (ø)
app/dashboard/views.py 11.24% <0.00%> (+0.01%) ⬆️
app/dashboard/embed.py 31.60% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae77056...2569304. Read the comment docs.

@thelostone-mc thelostone-mc merged commit c844584 into gitcoinco:master Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant