Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tribes Townsquare #6495

Merged
merged 41 commits into from
May 1, 2020
Merged

Tribes Townsquare #6495

merged 41 commits into from
May 1, 2020

Conversation

androolloyd
Copy link
Contributor

@androolloyd androolloyd commented Apr 23, 2020

Description

Tribes Townsquare Integrated View

Refers/Fixes

#6495

Testing

@thelostone-mc thelostone-mc marked this pull request as draft April 24, 2020 00:38
@androolloyd androolloyd marked this pull request as ready for review April 29, 2020 14:42
@androolloyd androolloyd changed the title WIP Tribes Townsquare Tribes Townsquare Apr 29, 2020
…ture/tribes-ts

adding in bounty explorer component into the tribes townsquare view, some changes to bring it into the code base
clean up work, and prep for v1 launch
@thelostone-mc
Copy link
Member

thelostone-mc commented Apr 29, 2020

@androolloyd yo we got conflict + CI failures (recreating migrations )

docker-compose.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@danlipert danlipert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some small fixes but nothing that would stop us from deploying I don't think. Lets make sure to get the fixes in at some point though

app/dashboard/views.py Show resolved Hide resolved
app/dashboard/views.py Outdated Show resolved Hide resolved
app/dashboard/views.py Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #6495 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6495   +/-   ##
=======================================
  Coverage   27.30%   27.30%           
=======================================
  Files         287      287           
  Lines       26801    26801           
  Branches     3962     3962           
=======================================
  Hits         7317     7317           
  Misses      19212    19212           
  Partials      272      272           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54fe055...54fe055. Read the comment docs.

Copy link
Contributor

@octavioamu octavioamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments, looking good

app/assets/v2/js/pages/profile-tribes.js Show resolved Hide resolved
app/dashboard/views.py Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@octavioamu octavioamu merged commit beb8056 into master May 1, 2020
octavioamu added a commit that referenced this pull request May 1, 2020
androolloyd added a commit that referenced this pull request May 4, 2020
thelostone-mc pushed a commit that referenced this pull request May 5, 2020
* move the new vuew response higher up the request to improve performance/lower serialization weight, if the new view fails, load the old view

* lots of little things, layout changes, and margin/padding adjustments for the majority of the coponents,
better responsive layouts
hide filters on mobile/smaller layouts

* quick layout fixes and some logo fixes

* Some style updates to the manage page, wired in the fund and cancel buttons

* Handler for Window Popstate

* Add response profile cards to townaquare

* Add responsiv view for people

* Revert "Revert "Tribes Townsquare (#6495)""

This reverts commit 8bfca7d.

* move the new vuew response higher up the request to improve performance/lower serialization weight, if the new view fails, load the old view

* lots of little things, layout changes, and margin/padding adjustments for the majority of the coponents,
better responsive layouts
hide filters on mobile/smaller layouts

* quick layout fixes and some logo fixes

* Some style updates to the manage page, wired in the fund and cancel buttons

* Handler for Window Popstate

* Add response profile cards to townaquare

* re enable some of the tribe header information

* Tribes V1 RC1
- style updates for tab rails.
fixes for the profile deatils component

* Fix conflicts with tribes

* Fix overlapping footer and cards

* updated filters for mobile, RC2

* fix for the profile details v-if check

* small change for min width of the sidebars

* fix tooltip text

* fix for defects noticed around HackathonProjects vue keys

* last minute fixes :(

* revert showing of the invite all button

Co-authored-by: Miguel Angel G <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants