Added 'My Project' section in hackathon projects #6494
Conversation
imtiaz101325
requested review from
danlipert,
octavioamu and
thelostone-mc
as code owners
Codecov Report
@@ Coverage Diff @@
## master #6494 +/- ##
==========================================
+ Coverage 26.67% 26.69% +0.02%
==========================================
Files 293 293
Lines 27878 27878
Branches 4113 4113
==========================================
+ Hits 7436 7442 +6
+ Misses 20176 20170 -6
Partials 266 266
Continue to review full report at Codecov.
|
| </div> | ||
| </div> | ||
| </div> | ||
| <h1 v-if="userProjects.length > 0" class="font-title title ml-2 mt-4">All Projects</h1> |
There was a problem hiding this comment.
^ seems like userProjects.length > 0 is repeated!
Wrap it within a <template> to make the code cleaner
| <div class="my-3 mb-2 text-left"> | ||
| <b class="font-weight-bold font-smaller-3">Team Members</b> | ||
| <div class="mt-1"> | ||
| <a v-for="profile in project.profiles" :href=`/profile/${profile.handle}` class=""> |
|
Hi @thelostone-mc sorry for taking my time to follow up on this. I have used a template and a for loop to avoid repeating the markup and cleaned up the empty class and style attributes. |
|
Sorry about that. Pressed |
|
@imtiaz101325 would you mind updating the style of buttons to look like this? View Prize button using an out line and blue text.
Thanks! |
|
@imtiaz101325 the section 1 /2 seems very unclear -> |
| @ [[ profile.handle ]] | ||
| </b-dropdown-item-button> | ||
| </b-dropdown> | ||
| <template v-for="section in 2"> |
There was a problem hiding this comment.
Can we simplify the code here and just repeat the html here rather than iterating with the section var and then checking it?
There was a problem hiding this comment.
That was my initial thought and I did repeat the markup on the previous commit. I could just revert to that.
|
@thelostone-mc I wanted to use components but the markup is currently using inline templates and I could not figure out how to use a component here. Which is why tried to use a loop to avoid repetition instead. |
|
Thanks for the reply @imtiaz101325, what do you suggest @danlipert ? |
|
@imtiaz101325 could you add an edit button as @octavioamu has suggested? this would only be visible to the person who created the project. Thanks! Happy to tip for this addition. |
- filtered existing data with user id - refactored card markup into component - added edit button to cards
|
@PixelantDesign I've added the edit button. Also rebasing the branch with master fixed the button styles. Here's a preview:
|
|
@thelostone-mc @danlipert refactored the card markup into a component. Please let me know if there's any other changes needed. |
|
Thank you @imtiaz101325! |
|
Can we deploy? |
Description
Added 'My Project' section in hackathon projects page
Refers/Fixes
Refs: #6442
Testing
If user is logged in and has matching projects the new section
My Projectsnow show those projects while the sectionAll Projectsshow all projectsTablet
Mobile
