Fix @mention recognition in Townsquare #6485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastiantf
requested review from
danlipert,
octavioamu and
thelostone-mc
as code owners
octavioamu
reviewed
Apr 21, 2020
octavioamu
approved these changes
Apr 21, 2020
thelostone-mc
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The existing regex to identify @mentions was also identifying the same that could occur in URLs like from medium: https://medium.com/@shevski/how-decentralised-are-you-a6539eeb27ff
The regex has been modified to correctly identify intended @mentions and not those in URLs.
Refers/Fixes
Fixes #6298
Testing
Original input to status update:
Before:
Also see: #6298 (comment)
After: