chore: cross-chain improvs #6472
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6472 +/- ##
==========================================
+ Coverage 27.18% 27.24% +0.06%
==========================================
Files 289 289
Lines 26464 26380 -84
Branches 3923 3909 -14
==========================================
- Hits 7194 7188 -6
+ Misses 19003 18925 -78
Partials 267 267
Continue to review full report at Codecov.
|
thelostone-mc
force-pushed
the
cross
branch
2 times, most recently
from
78bf123 to
9cda2bc
Compare
- remove unused admin methods - add activity on close bounty - fixed broken fa icons - updated tooltip design - added icon for expired fulfillment to inform user - set txn/address link based on token
| contactFunder: function() { | ||
| let vm = this; | ||
| let text = window.prompt('What would you like to say to the funder?', ''); | ||
|
|
||
| if (text === null) { | ||
| return; | ||
| } | ||
| document.location.href = `${vm.bounty.url}?admin_contact_funder=${text}`; | ||
| }, | ||
| snoozeeGitbot: function() { | ||
| let vm = this; | ||
| let text = window.prompt('How many days do you want to snooze?', ''); | ||
|
|
||
| if (text === null) { | ||
| return; | ||
| } | ||
| document.location.href = `${vm.bounty.url}?snooze=${text}`; | ||
| }, | ||
| overrideStatus: function() { | ||
| let vm = this; | ||
| let text = window.prompt('What new status (valid choices: "open", "started", "submitted", "done", "expired", "cancelled", "" to remove override )?', ''); | ||
|
|
||
| if (text === null) { | ||
| return; | ||
| } | ||
| document.location.href = `${vm.bounty.url}?admin_override_satatus=${text}`; | ||
| }, |
There was a problem hiding this comment.
why are we removing these actions? that will be undefined in the html vue click
There was a problem hiding this comment.
@octavioamu so those buttons don't work for ETH bounties as well!
Hence I made sure only the buttons which worked were being ported over
There was a problem hiding this comment.
I assumed those actions don't work in live !
https://gitcoin.co/issue/gitcoinco/web/6486/4252
So removed them out from the JS and the html for cross-chain
There was a problem hiding this comment.
I'll re-add the contactFunder and snooze bot but the override status -> let's not do that ?
There was a problem hiding this comment.
but eth bounties are not using this code
There was a problem hiding this comment.
the override status is something they use to manage hackathon bounties sometimes I believe
There was a problem hiding this comment.
lol that doesn't work :P cause that updates idx_status and not bounty_state
we'll fix this up if they ever bring it up 📦
| // ETH | ||
| activity.metadata.new_bounty['token_value'] = activity.metadata.new_bounty.value_in_token / 10 ** decimals; | ||
| if (activity.metadata.old_bounty) { | ||
| activity.metadata.old_bounty['token_value'] = activity.metadata.old_bounty.value_in_token / 10 ** decimals; | ||
| } | ||
| } else { | ||
| // cross-chain |
There was a problem hiding this comment.
are not going to jump and use this file in eth bounties in near future?
There was a problem hiding this comment.
I'd want to do it via the backend where we streamline the response and then pass it to the frontend !
Activity will be in common format when it comes to frontend (irrespective of if it's ETH or cross-chain)
| @@ -36,9 +36,6 @@ | |||
| Admin Actions | |||
| </span> | |||
| <a v-for="link in quickLinks" class="btn btn-outline-gc-blue px-2 mx-2 font-smaller-4" :href="[[link.href]]" :title="[[ link.title ]]">[[ link.label ]]</a> | |||
| <button class="btn btn-outline-gc-blue px-2 mx-2 font-smaller-4" @click="contactFunder()">Contact Funder</button> | |||
There was a problem hiding this comment.
these removed are not part of quickLinks since are not links, are prompts and I fixed them to not send the actions if are empty (today that is broken in normal bounties if you click that prompts then the action is sent even without nothing
Description