-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add banner and modal for user onboarding #6468
Conversation
looking good! Could hide the What is gitcoin banner @zoek1 ? Could you also provide a video of this feature working when a user is unauthenticated and logging in? This will help with the review process. Thanks!!!!! |
Sure @PixelantDesign :) |
@thelostone-mc another for review 🙏 |
@zoek1 it looks like we are missing the fourth link to townsquare ono the modal. |
@frankchen07 the purpose of the modal is not to see where people go.... |
@PixelantDesign / @frankchen07 could you give discuss this and tell us how to proceed ! |
…nto feature/onboarding
I added the missed button |
Codecov Report
@@ Coverage Diff @@
## master #6468 +/- ##
==========================================
+ Coverage 26.75% 27.09% +0.33%
==========================================
Files 293 291 -2
Lines 27538 27053 -485
Branches 4069 3985 -84
==========================================
- Hits 7369 7331 -38
+ Misses 19902 19454 -448
- Partials 267 268 +1
Continue to review full report at Codecov.
|
@zoek1 could we dynamically pull in the number of devs on the platform from this page? it’s around 40k, scrill to bottom to see. |
Covered @pixalantdesign, i added the code to show dynamically the number of devs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zoek1 could we update the logos using these files?
Gitcoin Products Logos_050120.zip
cc @octavioamu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the only missing here is use the logos in top-bar folder instead of adding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PixelantDesign I forgot to update the screenshot, the logos match on each section. |
@zoek1 could you share the screenshot of the logo matching? The last screenshot has the wrong logo. @octavioamu how does this link up with the web3 connect screen that you're working on? @zoek1 could we have a video of this experience? Thanks! |
Thanks for sharing the video @zoek1! I noticed the wallet screen keeps popping up. @octavioamu let's sync on the best way to handle this. It could be frustrating for the user. |
…nto feature/onboarding
FIxed on 99c0524 @octavioamu |
Description
Implement the banner and modal for user onboarding on Figma
DEMO:
https://www.loom.com/share/8d484cd6ecb142cf8ed49d2ba493de14
Refers/Fixes
Testing